refactor: auth logic and user creation logic; improve test isolation#22
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 62.73% 68.06% +5.33%
==========================================
Files 18 15 -3
Lines 432 404 -28
==========================================
+ Hits 271 275 +4
+ Misses 161 129 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ReenigneArcher
force-pushed
the
dev
branch
3 times, most recently
from
dfc99de to
50900d3
Compare
ReenigneArcher
changed the title
ReenigneArcher
force-pushed
the
dev
branch
6 times, most recently
from
8f9755a to
288e89a
Compare
Refactors authentication to use BCrypt for password hashing and verification, removes explicit password salt fields from the schema, and improves JWT secret handling. User creation now hashes passwords and PINs using BCrypt, and admin privileges are required for creating users after the first. Adds comprehensive integration and unit tests for authentication, user creation, and protected routes, and introduces shared test utilities to reduce code duplication. Removes unused dependencies (serial_test, tokio) and updates test infrastructure for isolated, parallel test execution.
|
ReenigneArcher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors authentication to use BCrypt for password hashing and verification, removes explicit password salt fields from the schema, and improves JWT secret handling. User creation now hashes passwords and PINs using BCrypt, and admin privileges are required for creating users after the first. Adds comprehensive integration and unit tests for authentication, user creation, and protected routes, and introduces shared test utilities to reduce code duplication. Removes unused dependencies (serial_test, tokio) and updates test infrastructure for isolated, parallel test execution.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage